From bbe3424499474ca673eb81b343b742f21bd6a50f Mon Sep 17 00:00:00 2001
From: dangered wolf <d@ngeredwolf.me>
Date: Tue, 2 Jan 2024 20:10:33 -0500
Subject: [PATCH] Don't duplicate embedding client regex

---
 src/worker.ts | 19 ++++---------------
 1 file changed, 4 insertions(+), 15 deletions(-)

diff --git a/src/worker.ts b/src/worker.ts
index 9bd994a..e2b2d5e 100644
--- a/src/worker.ts
+++ b/src/worker.ts
@@ -10,6 +10,7 @@ import { twitter } from './realms/twitter/router';
 import { cacheMiddleware } from './caches';
 
 const noCache = 'max-age=0, no-cache, no-store, must-revalidate';
+const embeddingClientRegex = /(discordbot|telegrambot|facebook|whatsapp|firefox\/92|vkshare)/gi;
 
 /* This is the root app which contains route trees for multiple "realms".
 
@@ -84,11 +85,7 @@ app.onError((err, c) => {
     errorCode = 504;
   }
   /* We return it as a 200 so embedded applications can display the error */
-  if (
-    c.req
-      .header('User-Agent')
-      ?.match(/(discordbot|telegrambot|facebook|whatsapp|firefox\/92|vkshare)/gi)
-  ) {
+  if (c.req.header('User-Agent')?.match(embeddingClientRegex)) {
     errorCode = 200;
   }
   c.status(errorCode);
@@ -139,11 +136,7 @@ app.route(`/twitter`, twitter);
 app.all('/error', async c => {
   c.header('cache-control', noCache);
 
-  if (
-    c.req
-      .header('User-Agent')
-      ?.match(/(discordbot|telegrambot|facebook|whatsapp|firefox\/92|vkshare)/gi)
-  ) {
+  if (c.req.header('User-Agent')?.match(embeddingClientRegex)) {
     c.status(200);
     return c.html(Strings.ERROR_HTML);
   }
@@ -166,11 +159,7 @@ export default {
         errorCode = 504;
       }
       /* We return it as a 200 so embedded applications can display the error */
-      if (
-        request.headers
-          .get('user-agent')
-          ?.match(/(discordbot|telegrambot|facebook|whatsapp|firefox\/92|vkshare)/gi)
-      ) {
+      if (request.headers.get('user-agent')?.match(embeddingClientRegex)) {
         errorCode = 200;
       }